LB (Ben Johnston)

icon indicating a website link https://lb.ee icon indicating an email [email protected]

icon company Virgin Australia icon location Brisbane, Australia icon location LB (pronounced ‘Albi’), love coffee, systems, travel, technology and also coffee. Incredibly thankful for my amazing wife Bec and son Leo.

Results 1054 comments of LB (Ben Johnston)

Upgrade notification stimulus

@Lovelyfin00 the test is still failing. You may need to refine the test to work with the new data attributes approach where we always have some data attributes for the...

Upgrade notification stimulus

Assigning to myself for another review.

Add missing TZ conversions and date formatting

Haven't had a chance to run locally but the code all makes sense and appears to be solid. I'll do my best to run through your testing instructions tomorrow.

Add missing TZ conversions and date formatting

Thanks @th3hamm0r for the additional steps to get this tested, sorry I did not get a chance to do this earlier. I am still keen to understand and review this...

Add missing TZ conversions and date formatting

Sorry I haven't reviewed this yet, I actually saw the issue you've described while testing the bakerydemo Squash build today. It was saying my last edit on a page was...

Add missing TZ conversions and date formatting

@th3hamm0r I think we should lean towards a 'safer' migration that does not error so let's leave this as is. Can you please prepare another PR that just adds the...

Add missing TZ conversions and date formatting

Thanks @th3hamm0r

Ensure the Page chooser modal listing uses buttons

Rebased

Ensure the Page chooser modal listing uses buttons

Rebased

Ensure the Page chooser modal listing uses buttons

Will close this for now, been over 6 months of rebasing / fixing conflicts - obviously not a big priority at this time. I will comment on the original issue...