Lauri Tulmin

Results 218 comments of Lauri Tulmin

@atshaw43 Firstly the module name `message-handler` doesn't seem appropriate as the code seems to deal only with aws messages. Perhaps it should be named `aws-something-something` or even be moved to...

The underlying code has changed so this PR is no longer relevant.

@zeitlinger some of the review comments I left apply to multiple locations, could you apply the same changes everywhere where the same pattern is used

This is a mistake in the release notes. Contrib release [1.37.0](https://github.com/open-telemetry/opentelemetry-java-contrib/releases/tag/v1.37.0) targets sdk 1.4.0.

> Can we make this 1.41.0 instead? Because of the removal of `okhttp3` from `aws-resources`? https://github.com/open-telemetry/opentelemetry-java-contrib/releases/tag/v1.38.0 targets sdk 1.41.0

A PR would be welcome. You may wish to check whether your handling of nanoseconds in the non instant case is correct. I suspect that you may need to truncate...

@cbos are you doing this for fun or do you intend to get this merged?

> Span links, only link one span to the other. But the context is not propagated. Especially baggage headers are mend for context propagation. But that is missing right now....

I'd try writing an extension https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/examples/extension that adds a [span processor](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/examples/extension/src/main/java/com/example/javaagent/DemoSpanProcessor.java) You'd need to implement https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/internal/ExtendedSpanProcessor.java and use the `onEnding` callback.