Lauri Tulmin
Lauri Tulmin
@tylerbenson could you help reviewing this
There are a few things to consider with this instrumentation. Firstly it only updates the jdbc library instrumentation, ideally we'd like to have the same features in the library instrumentation...
Perhaps we should rewrite the spring boot kafka instrumentation in a different way. Besides not working with custom interceptors there is another issue with batch interceptors not working correctly with...
I think you should split this PR in 2. The first one should just do the changes that are needed to make the instrumentation work with indy like adding the...
> Unfortunately, I think we can't do that, as migrating to indy advices means removing the local variables. As far as I remember the advice transformer can rewrite `@Advice.Local`, so...
> IMO, the Consumer approach for Advices feels a bit more complicated, though it preserves type safety. However this comes at the cost of allocation of which I'm not sure...
@SylvainJuge I wanted to create a PR for your PR that does this a bit differently, but with your last changes it won't apply cleanly and I don't have time...
We'd need a minimal application that reproduces the issue to determine why exactly it is logged.
If you believe you have found a bug then please provide a minimal sample application that reproduces the bug.