Lauri Tulmin
Lauri Tulmin
The agent can be customized via [extensions](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/examples/extension). Extensions can implement the SPIs from https://github.com/open-telemetry/opentelemetry-java/tree/main/sdk-extensions/autoconfigure-spi and use them to customize the opentelemetry sdk used by the agent. Unfortunately there doesn't seem...
> @laurit can you please review this There are no tests. You didn't add your module to `settings.gradle.kts` so it is unknown whether it compiles.
> **Recommendation 2: folder structure**: I'd recommend restructurctuing the entire thing to adhere to the [Folder Structure Style Guide](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/contributing/writing-instrumentation.md#folder-structure). where you have 3 main directories, javaagent, library and testing directories....
> Thanks @laurit for clearing up the Library vs Agent instrumentation. I was assuming that the rule was you need to create both as that was what I was required...
> @laurit , all checks have passed. can you please review there are still no tests, do you plan to add them?
> Doing this means that the generateLicenseReport could be executed systematically to keep the license-report up-to-date when changes are made to dependencies, for example using a git pre-commit or pre-push...
Resolved with https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/12359 and https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/12373
> Any clue why in 'markdown-link-check' job following links are failing: > > ``` > [✖] https://maven-badges.herokuapp.com/maven-central/io.opentelemetry/opentelemetry-api → Status: 503 > [✖] https://maven-badges.herokuapp.com/maven-central/io.opentelemetry/opentelemetry-api/badge.svg → Status: 503 > ``` > >...
> will match /fooabc/123, but no http.route is generated. Given the glob-style approach of using * to represent a captured variable, I suggest the correct http.route here should be /foo**...
> If not using the Javaagent, would registering a `SpanProcessor` solve this use case? > I believe so. It should be possible to implement a `SpanProcessor` that reads the actual...