Lauri Tulmin
Lauri Tulmin
@aarrsseni your configuration https://github.com/aarrsseni/demo-sqs-opentelemetry/blob/73a79bbcb059f70ee244fc551d8b2ef642c20eeb/src/main/resources/application.yml#L9 sets endpoint to `http://docker:4566` is that localstack? If it is localstack then as far as I know localstack propagates aws trace headers only in commercial version....
This will require instrumentation for `@SqsListener`. There is also https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/4788
> Are the changes in 2.9 javaagent version applicable only for spring boot version>=3? I believe so
> Is splunk-otel-java agent safe to use with virtual threads? Yes, there are no bug reports for either the splunk otel java agent or the upstream otel java agent that...
This PR adds an option to capture the unformatted (placeholders not replaced) log message along with arguments that will substitute the placeholders. I think this will need to be raised...
> Are you with your colleagues make decisions on this week and write conclusion and recommendation for this PR in comment here? There is a weekly SIG meeting on Thursday...
> We followed the same logic to implement our tracing instrumentation. When calling Span.addEvent() method to add an event, we passed in the timestamp created from a similar getNanos() method....
> If a span is started by calling [Instrumenter.doStart()](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/Instrumenter.java#L166) with a null startTime argument and is ended by calling [Instrumenter.doEnd()](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/Instrumenter.java#L227) with a non-null endTime argument, the calculated duration for this...
> [@laurit](https://github.com/laurit) Good point! we can view this as a misues of the api. In this case, it is better to guide the startTime and endTime arguments in the api...
@atshaw43 we already have aws lambda instrumentation in https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/aws-lambda/aws-lambda-events-2.2/library