Lauri Tulmin
Lauri Tulmin
@adamleantech thanks for reporting, I'll fix it
[We'd welcome a contribution for this](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/ISSUES.md#contribution-welcome)
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/10573 will conflict with this change as after that change some attributes will be missing when test is using `SniEndPoint`
https://opentelemetry.io/docs/specs/semconv/resource/process/ states that `process.command`, `process.command_args` and `process.command_line` are required.
> this is sent on every single event with otlp exporter resource attributes are sent once per batch of exported data
@rombert could you also add tests for your instrumentation
@rombert with cassandra there is no need to inject the agent into the image as we are testing cassandra client not the server. Tests that inject agent into an image...
> In `NonRegisteringTrinoDriver`, we try to instantiate `OkHttpTelemetry` while ignoring `NoClassDefFoundError`. Is that code guaranteed to throw `NoClassDefFoundError` if `opentelemetry-extension-incubator` is not present on the classpath? yes, it is >...
@jack-berg I have modified the PR as you suggested
> if you're up for it, can you open a new PR with the scope reduced to spans? If not, I'm happy to help. I'll start working on it tomorrow.