Laura Brehm
Laura Brehm
Hiya @Theiaz, thanks for the report. Indeed, the current zsh completion script is a bit broken for container name completion – I started looking into fixing this some time ago,...
Do you mean the script generated by `docker completion zsh` doesn't do anything at all? I'd recommend checking the output of `docker completion zsh --help` to see some more information...
@thaJeztah can you TA(nother)L?
@jsternberg's PR https://github.com/docker/cli/pull/4889 just got merged 🥳 Can you rebase and see if everything's fine @krissetto?
Just so I don't forget this, can you get code into `telemetry.go` to accept a `OTEL_EXPORTER_OTLP_ENDPOINT` env var in this PR too @krissetto?
@jsternberg wanna take a final look? :')
@thaJeztah care to take a final look at this?
Re: > I would like to also move the code out that catches the os.Signal to somewhere in the main function so we have a top-level way of handling SIGTERM...
Hiya @mrasu, sorry for the delay in replying – Indeed, we started setting `OTEL_RESOURCE_ATTRIBUTES` which would break setups such as yours. This wasn't the intention, and I guess there's a...
Chatted w/ @jsternberg, there's some other approaches that would be interesting to look at (take care of shutdown automatically in the CLI lifecycle), but he's okay with merging as-is for...