Laura Brehm
Laura Brehm
Took a look at https://github.com/rumpl/moby/pull/92 and added a commit moving `readOnly()` over to `oci.ReadonlyMounts()`. I still want to look at/play around a little bit with `snapshotter.View` though, reading it I...
Added a commit to skip the failing BuildKit tests: see https://github.com/moby/moby/pull/44964#issuecomment-1481581382 - https://github.com/moby/buildkit/pull/3736 (took some inspiration from https://github.com/moby/moby/pull/45112/files)
Rebased on top of https://github.com/moby/moby/pull/44958, which includes the necessary refactors to address @neersighted's comment's here – https://github.com/moby/moby/pull/44934#discussion_r1102022773. Only the last commit includes actual relevant changes for this PR, the others...
@vvoland can you take another look and then I'll merge?
Voting for left-alined first-column header 😅 Could we also left-align the other columns? I like that more imo
Whole columns left-aligned looks better to me! (but that's subjective, I'm just casting my vote here) (this image) I'm also a +1 on adding content size, I think this is...
Nice! I didn't know about right-alined numbers, but it makes sense – this way, the decimal places are aligned, which also makes it easier to parse the table and find...
@krissetto @Benehiko can you TAL?
To add a little more info, the "early write" was originally added in https://github.com/moby/moby/commit/1cbf5a54dae86e34d8e65508c5640b17cda0eed8. Ahh, beat me to it @thaJeztah .
This seems like the cleanest/least-hacky fix for this, thanks!