improve passing context
- relates to https://github.com/docker/cli/pull/4698
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 61.08%. Comparing base (
8651906) to head (709df33).
Additional details and impacted files
@@ Coverage Diff @@
## master #4774 +/- ##
=======================================
Coverage 61.08% 61.08%
=======================================
Files 295 295
Lines 20660 20660
=======================================
Hits 12621 12621
Misses 7142 7142
Partials 897 897
Let me move this one out of draft, but please have a close look to see if the approach makes sense. I recall I was fiddling a bit with passing the context with the combination of closures and call-sites of different parts of the code.
@thaJeztah can you TA(nother)L?
Ah, one more thing, can you please add the changelog description with highlighting the API change?
EDIT: Sorry, I confused PRs 🙈 There was no API change in the end here (we didn't alter the RunPlugin signature), so no need for changelog!
Ah, one more thing, can you please add the changelog description with highlighting the API change?
EDIT: Sorry, I confused PRs 🙈 There was no API change in the end here (we didn't alter the
RunPluginsignature), so no need for changelog!
@vvoland You had the PR right, I just reverted those changes in the PR and squashed the commits