cli icon indicating copy to clipboard operation
cli copied to clipboard
verified publisher icon docker

Centralize init of Meter/TracerProviders

Open krissetto opened this issue 1 year ago • 1 comments

- What I did

  • Centralized init of Meter/TracerProviders
  • Changed Meter/TracerProvider funcs on DockerCli to return the providers rather than initialize them

- Description for the changelog

Centralize initialization of Meter/TracerProviders

- A picture of a cute animal (not mandatory but encouraged)

krissetto avatar May 13 '24 12:05 krissetto

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 61.35%. Comparing base (6c70360) to head (02537ea). Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5067      +/-   ##
==========================================
+ Coverage   61.09%   61.35%   +0.26%     
==========================================
  Files         298      298              
  Lines       20675    20685      +10     
==========================================
+ Hits        12631    12691      +60     
+ Misses       7147     7093      -54     
- Partials      897      901       +4

codecov-commenter avatar May 13 '24 12:05 codecov-commenter

Chatted w/ @jsternberg, there's some other approaches that would be interesting to look at (take care of shutdown automatically in the CLI lifecycle), but he's okay with merging as-is for now to unblock releases and improving things later.

laurazard avatar May 14 '24 14:05 laurazard