Laura Brehm

IMO a big part of why I want this change is to make local development easier, so Testcontainers don't really achieve that. I'm okay with shell scripts are they're portable...

@thaJeztah does this LGTY?

Looks like the linter's complaining, and some tests are broken because now the output from the graceful termination logic is different: ``` === FAIL: e2e/cli-plugins TestPluginSocketCommunication/detached/the_main_CLI_exits_after_3_signals (1.10s) socket_test.go:232: assertion failed:...

Good point from @tonistiigi here – https://github.com/docker/cli/pull/4888#discussion_r1525644870. A more holistic approach would be to always set up signal handling in the CLI, and use it to cancel the command's context,...

@neersighted @thaJeztah can you TAL when you get a sec?

@thaJeztah @vvoland @krissetto @Benehiko rewrote the hook templates using Go Templates, PTAL if you get a sec :)

I called that out in the performance section of the PR description, and took steps to avoid that (running with a fake terminal), no? Anyway, I'm looking from my phone...

Alright, I'm back at a keyboard now: > Note that hyperfine does not show correct numbers as this feature is disabled in non-terminal in the current PR. Right, that's why...

Replying here to provide a coherent response to the concerns brought up by @tonistiigi: To properly test performance, I made the following changes to `cmd/docker/docker.go`: ```diff diff --git a/cmd/docker/docker.go b/cmd/docker/docker.go...

This (current) performance discussion is moot as we'll be making some implementation changes that allow us to not have to scan/execute all the plugins, but for discussion's sake: > You...