Eric Larson

Results 1629 comments of Eric Larson

@withmywoessner do you have time to come back to this or would it help if someone pushed commits?

> It uses Cython and compiled extensions for performance-critical operation (which can also be a con, I haven't checked whether they provide up-to-date binary wheels). Doesn't [look like it](https://pypi.org/project/surfa/#files): Would...

@timhoffm that sounds like a good plan to me

Rather than changing `70_report.py` the idea -- since it's complementary info -- would be to create a new tutorial/example instead

> use pathlib.Path instead of plain strings + os.path Would be awesome! > add type annotations Sure -- if we do this let's to add `mypy` or similar checking in...

> BUT in the same example, a few lines below, initialize_3D_wong_radial is not linked, both functions are from the same module Our detection and implementation of this stuff can be...

Makes sense to me, at least in cases where `method` is something that actually uses the positions (which is true for MEG sensors by default, but wouldn't be for `method="nan"`...

@drammock I don't see this as a blocker for release so pushing to 1.12