Eric Larson
Eric Larson
I don't know of anyone looking into this so yes some minimal reproducer would be a good start!
I think there are a couple of things we could do. My first thought was to switch plot_events to use the constrained layout engine. It's almost always better about spacing....
> or did you have something else in mind? Nope that's what I had in mind, just didn't look at the code :facepalm:
Thanks for tackling this! Just one quick idea comes to mind for: > [effcf01](https://github.com/numpy/numpydoc/commit/effcf01e9d9e0f3c24949dffea6c90f652fd925e) : Split the docscrape tests into two test modules... Have you considered [splitting while keeping blame](https://stackoverflow.com/questions/3887736/keep-git-history-when-splitting-a-file/53849651#53849651)?...
This looks like it's headed in the right direction! If you look at [one CI failure](https://dev.azure.com/mne-tools/mne-python/_build/results?buildId=33236&view=logs&jobId=dded70eb-633c-5c42-e995-a7f8d1f99d91&j=dded70eb-633c-5c42-e995-a7f8d1f99d91&t=1ccededa-7e7e-5a92-87ce-e531d760d025), you'll see: ``` ________________ ERROR collecting mne/stats/tests/test_erp.py _________________ mne\stats\tests\test_erp.py:14: in raw = read_raw_fif(base_dir /...
> It would make more sense to me to set it as 0 (as an integer), the same way as subject_info["id"] is anonymized. Agreed, I think you can make this...
I like (1), seems like a hopefully low-effort solution!
In MNE-Python we do (see for example [here](https://mne.tools/dev/auto_tutorials/inverse/30_mne_dspm_loreta.html) where it has an effect): ``` div.sphx-glr-animation video { max-width: 100%; height: auto; } ``` so I think we have some similar...
I wonder if the best thing here would be `matplotlib_animations_options` which are reST options passed to the directive, so the default would be: ``` :class: sphx-glr-single-img :height: 960 :width: 1280...
Thinking a bit more... we already have `matplotlib_animations`, which currently can be a `tuple`. I think we should change this to a `dict` in a backward-compatible way, i.e., still alllow...