Eric Larson
Eric Larson
Oh okay with me then!
> I agree with Clemens and Mathieu, the FIFF format often places an unnecessary limit on our plans of supporting more (or more detailed) (meta-) data. I am also aware...
> Fair enough, but this is hopefully not set in stone, so I'd rather discuss it again from time to time. This means it is bothering people enough apparently that...
> If we make changes to the "FIFF spec", are we talking about some official file format specification that is then also respected by every other user? Or are we...
> @larsoner I've never seen this discussed here, except maybe in #5302, but there hasn't been any definitive answer. You should look more broadly into discussions of `raw.save` vs `mne.export`....
@WouterKroot would you be up for adding support for BUTTON events? And maybe the default `create_annotations=True` should include these events (would count as an enhancement I think). cc @scott-huberty
Or even better than adding a whole new file, take an existing file, copy to temp dir in a test while modifying it to add a button line / lines,...
Things build and import okay in #66 with no additional flags. If things don't actually work, would be good to add more comprehensive tests that would show the problems
Looks like style CIs are unhappy -- until they are, most tests won't run
@zEdS15B3GCwq friendly ping on this one, still interested in moving this one forward?