Eric Larson

Results 1629 comments of Eric Larson

Thanks for the summary and the great work @Genuster !

Nowadays many repos (including mne-python)R use dynamic versioning. That is, the `package.__version__` is figured out by the packaging system based on tagged releases and a given versioning scheme (usually semantic)....

> decide whether this belongs in MNE-Python, MNE-BIDS, or a separate package. I don't have strong feelings here; I implemented in MNE-Python first because it was easiest, but I'm happy...

Pushing to 1.12

I suspect it has to do with the `annotation_regex`... it's likely that interacting with that subset of annotations won't index properly back into the original `raw.annotations` to update them or...

> Where is the best place to list the suffix mappings @larsoner? Looks like the mapping currently lives here https://github.com/mne-tools/mne-python/blob/b38385ef90d0fd8214d54b15c5fd91333c3bc032/mne/annotations.py#L1203

> Should I add tests and include a citation for the library somewhere? Sure, it would be good to add it to `environment.yml` (and to conda-forge if it's not already...

https://github.com/mne-tools/mne-testing-data/releases/tag/0.157

Whoops I missed that! Will fix both and cut a new version

Done... use 0.158 :facepalm: