lance6716

Revert "tidb lightning: expose [tidb.session-vars] in lightning config (#17864)"

1

Reverts pingcap/docs#17866 PR is not merged into v6.5 yet https://github.com/pingcap/tidb/pull/47500

[DNM]add log

2

### What problem does this PR solve? Issue Number: Close #xxx ### What is changed and how does it work? ```commit-message ``` ### Check List Tests - Unit test -...

## Enhancement Task There are some special error types like violation of WithOutputMustContainAllKeyRange. PD client should provide a function to let caller identify them quickly, rather than https://github.com/tikv/pd/blob/e8c05e0e28e39e345b26f23de237879a90f9a752/client/client.go#L1715-L1725 Or it's...

## Enhancement Task Callers sometimes have their own logic to check the leader of regions from scan regions API https://github.com/pingcap/tidb/blob/7e73ddc91b5f9f089e84f0dc645cf71a27b2ad50/br/pkg/restore/split/split.go#L72 https://github.com/tikv/client-go/blob/88ce38492f7b30d95f4e3a7c760ba44c9a32f1be/internal/locate/region_cache.go#L2328-L2339 I prefer the client can provide an option to...

importinto: explicitly return error for SET subquery

7

### What problem does this PR solve? Issue Number: ref #55497 Problem Summary: ### What changed and how does it work? ### Check List Tests - [ ] Unit test...

br, lightning: move region cover check into pd client

8

### What problem does this PR solve? Issue Number: ref #51533 Problem Summary: ### What changed and how does it work? to include https://github.com/tikv/pd/pull/8375 ### Check List Tests - [...

Callers don't need to care about new errors in GetTS

4

``` tidb lightning encountered error: [Lightning:KV:ErrCreateKVClient]create kv client error: rpc error: code = Unknown desc = [PD:tso:ErrGenerateTimestamp]generate timestamp failed, requested pd is not leader of cluster ``` https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_lightning_integration_test/detail/pull_lightning_integration_test/2225/pipeline Please auto-retry...

use golang built-in functions rather than mathutil

10

## Enhancement like we can use `max` rather than https://github.com/pingcap/tidb/blob/7158ac65ee454d38455cd636b562649b08906e18/pkg/util/mathutil/math.go#L71-L80

add index can not be canceled timely

1

## Bug Report Please answer these questions before submitting your issue. Thanks! ### 1. Minimal reproduce step (Required) `func (dc *ddlCtx) handleRangeTasks` is executed on a single goroutine. There's a...

## Bug Report Please answer these questions before submitting your issue. Thanks! ### 1. Minimal reproduce step (Required) capture a CPU profile when lightning encodes KV  https://github.com/pingcap/tidb/blob/ff2feb6653846b0decd8b1d7cc0a665e128ccf26/br/pkg/lightning/backend/kv/sql2kv.go#L491-L497 some implementations...