tidb
tidb copied to clipboard
importinto: explicitly return error for SET subquery
What problem does this PR solve?
Issue Number: ref #55497
Problem Summary:
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [x] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @lance6716. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.0461%. Comparing base (
87244ed) to head (672932a). Report is 9 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #55495 +/- ##
================================================
+ Coverage 72.9679% 75.0461% +2.0782%
================================================
Files 1582 1582
Lines 442744 444160 +1416
================================================
+ Hits 323061 333325 +10264
+ Misses 99932 90663 -9269
- Partials 19751 20172 +421
| Flag | Coverage Δ | |
|---|---|---|
| integration | 49.1690% <100.0000%> (?) |
|
| unit | 72.2336% <0.0000%> (+0.1234%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.9567% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 52.1028% <ø> (+6.6344%) |
:arrow_up: |
[LGTM Timeline notifier]
Timeline:
2024-08-29 01:52:10.681501803 +0000 UTC m=+1007925.815951916: :ballot_box_with_check: agreed by fzzf678.2024-08-29 01:53:21.820295728 +0000 UTC m=+1007996.954745849: :ballot_box_with_check: agreed by CbcWestwolf.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AilinKid, CbcWestwolf, fzzf678
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [AilinKid,CbcWestwolf]
- ~~pkg/planner/OWNERS~~ [AilinKid]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest
/retest
/retest
/retest
/retest
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.