tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br, lightning: move region cover check into pd client

Open lance6716 opened this issue 1 year ago • 8 comments

What problem does this PR solve?

Issue Number: ref #51533

Problem Summary:

What changed and how does it work?

to include https://github.com/tikv/pd/pull/8375

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [x] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

lance6716 avatar Jul 23 '24 08:07 lance6716

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jul 23 '24 08:07 tiprow[bot]

/test all

hawkingrei avatar Jul 23 '24 08:07 hawkingrei

/ok-to-test

hawkingrei avatar Jul 23 '24 08:07 hawkingrei

Codecov Report

:x: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 75.0681%. Comparing base (cf4bb51) to head (a3e117c). :warning: Report is 2729 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54833        +/-   ##
================================================
+ Coverage   74.7249%   75.0681%   +0.3432%     
================================================
  Files          1558       1590        +32     
  Lines        363817     448006     +84189     
================================================
+ Hits         271862     336310     +64448     
- Misses        72284      90420     +18136     
- Partials      19671      21276      +1605     
Flag Coverage Δ
integration 50.6463% <73.3333%> (?)
unit 71.6797% <96.6666%> (-2.5261%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (∅)
parser ∅ <ø> (∅)
br 62.9021% <96.6666%> (+14.4376%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 23 '24 09:07 codecov[bot]

/retest

lance6716 avatar Jul 26 '24 01:07 lance6716

/retest

lance6716 avatar Jul 26 '24 02:07 lance6716

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from lance6716 and additionally assign 3pointer for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 26 '24 05:07 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Nov 08 '24 08:11 ti-chi-bot[bot]

@lance6716: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 a3e117cf84e46a47f839cd5bad512cbb6138e062 link true /test check-dev2
pull-lightning-integration-test a3e117cf84e46a47f839cd5bad512cbb6138e062 link true /test pull-lightning-integration-test
pull-integration-e2e-test a3e117cf84e46a47f839cd5bad512cbb6138e062 link true /test pull-integration-e2e-test
pull-integration-realcluster-test-next-gen a3e117cf84e46a47f839cd5bad512cbb6138e062 link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen a3e117cf84e46a47f839cd5bad512cbb6138e062 link true /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Sep 26 '25 15:09 ti-chi-bot[bot]