pingcap
schematracker: add an unit test to cover an usage
Signed-off-by: lance6716 [email protected]
What problem does this PR solve?
Issue Number: ref https://github.com/pingcap/tidb/issues/35933
Problem Summary:
What is changed and how it works?
in DM integration tests, I found a surprising requirement of SchemaTracker, so add an unit test to make sure the behaviour will not change in future
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[REVIEW NOTIFICATION]
This pull request has been approved by:
- buchuitoudegou
- xhebox
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/0fb0760cfe5af212635da21fcd7bdc7801973e86
This pull request has been accepted and is ready to merge.
TiDB MergeCI notify
🔴 Bad News! New failing [1] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!
| CI Name | Result | Duration | Compare with Parent commit |
|---|---|---|---|
| idc-jenkins-ci-tidb/integration-common-test | 🟥 failed 1, success 16, total 17 | 13 min | New failing |
| idc-jenkins-ci/integration-cdc-test | 🟢 all 36 tests passed | 36 min | Existing passed |
| idc-jenkins-ci-tidb/common-test | 🟢 all 11 tests passed | 12 min | Existing passed |
| idc-jenkins-ci-tidb/tics-test | 🟢 all 1 tests passed | 8 min 14 sec | Existing passed |
| idc-jenkins-ci-tidb/integration-ddl-test | 🟢 all 6 tests passed | 5 min 53 sec | Existing passed |
| idc-jenkins-ci-tidb/sqllogic-test-2 | 🟢 all 28 tests passed | 5 min 12 sec | Existing passed |
| idc-jenkins-ci-tidb/sqllogic-test-1 | 🟢 all 26 tests passed | 5 min 2 sec | Existing passed |
| idc-jenkins-ci-tidb/mybatis-test | 🟢 all 1 tests passed | 3 min 15 sec | Existing passed |
| idc-jenkins-ci-tidb/integration-compatibility-test | 🟢 all 1 tests passed | 2 min 54 sec | Existing passed |
| idc-jenkins-ci-tidb/plugin-test | 🟢 build success, plugin test success | 4min | Existing passed |