Jan Lahoda comments

Results 98 comments of


                                            Jan Lahoda

8291769: Translation of switch with record patterns could be improved

> just curious: is there any performance degradation in the compilation time while compiling `long` test cases? I tried with a switch with 512+1 cases (record pattern for triplet, with...

JDK-8282434: Leading combining diacritic character in string renders incorrectly

/integrate

8294550: Sealed check for casts isn't applied to array components

/integrate

8328536: javac - crash on unknown type referenced in yield statement

I apologize for a belated reply. I agree with not adding a null check, that is usually a wrong/insufficient approach. And I think I agree with your approach, but I...

8327512: JShell does not work correctly when a class named Object or Throwable is defined

/integrate

8331051: Add an `@since` checker test for `java.base` module

/reviewers 2

8329581: Java launcher no longer prints a stack trace

My personal comments here: - I am fine with a solution like this. In 18753, I wanted to avoid a change of dynamics between the Java helper and the native...

Module Java Refactoring threw java.lang.IllegalStateException: java.lang.NullPointerException: Cannot invoke "com.sun.tools.javac.code.Type.getThrownTypes()" because "tree.meth.type" is null

The best is to have a way to reproduce - that it can be reported against javac and fixed there (and it is not rare that bugs like this are...

-Xlint:all breaks nb-javac 21

Thanks for the

-Xlint:all breaks nb-javac 21

Thanks for the report, filled: https://bugs.openjdk.org/browse/JDK-8322159