Jan Lahoda comments

Results 98 comments of


                                            Jan Lahoda

-Xlint:all breaks nb-javac 21

I've opened a backport to JDK 22, but then it unfortunately slipped through, so this was only fixed in JDK 22u. Yes, I think we'll need to upgrade to JDK...

Fails to parse a file with incomplete switch expression

FWIW, I've filled: https://bugs.openjdk.org/browse/JDK-8331212 have a (potential) fix, will open a PR sometime soon.

Declarative hint variable seems to capture too much

When matching, the variable will be put into both `variables` and `variables2Name`, to keep other stuff (like conditions) working. I suspect we need to keep this, and this is more...

8326333: jshell <TAB> completion on arrays is incomplete

/integrate

Add new method JavaShellToolBuilder.windowSize().

Sorry for belated reply. This makes sense to me.

Add new method JavaShellToolBuilder.windowSize().

/sponsor

8328536: javac - crash on unknown type referenced in yield statement

We've discussed with @mcimadamore offline, and changing the output for `T7188968` based on the change I've suggested yesterday is probably OK. I am pretty sure the output for the other...

8332106: VerifyError when using switch pattern in this(...) or super(...)

/integrate

Fixing 'nbls.project.resolveProjectProblems' command name.

Turned out that when the priming build fails, there is no notification to the user. Trying to improve that in: https://github.com/apache/netbeans/pull/7370/commits/d826509b9b3f69101ce2526cb864722d71ded220

Support for requires.nb.javac modules with javac.source/target > 8.

FWIW - I've merged with master (to get `javac.release`), and tried adjust this patch for that: https://github.com/apache/netbeans/pull/7201/commits/a7e81d3f49dfe5b05adeb0365612b98f40bb4e29 Also tried to fix `apisupport.ant` to support the `--limit-modules`. The effective way is...