JDK-8282434: Leading combining diacritic character in string renders incorrectly

[lahodaj]

There's a group of characters, that add diacritics to the preceding character. JShell wraps String values into double quotes, and so when such a combining character is the first character of a string, there is a double quote followed by the diacritics. On some terminals, it may print the diacritics merged with the double quote.

Sadly, the behavior seems to differ much between terminals, so the proposal here is to use Unicode escape sequences for these characters when they would immediately follow the opening double quote. Sample output: $1 ==> "\u032Ea"

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8282434: Leading combining diacritic character in string renders incorrectly

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9540/head:pull/9540
$ git checkout pull/9540

Update a local copy of the PR:
$ git checkout pull/9540
$ git pull https://git.openjdk.org/jdk pull/9540/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9540

View PR using the GUI difftool:
$ git pr show -t 9540

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9540.diff

[bridgekeeper[bot]]

:wave: Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (4b3ac74a)

[bridgekeeper[bot]]

@lahodaj This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk[bot]]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282434: Leading combining diacritic character in string renders incorrectly

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 527 new commits pushed to the master branch:

• bd674dc55e87940f442cb140841f95424b6d42fd: 8293163: G1: Rename G1HeapRegionAttr::is_humongous
• 479795b4d1aaf5be1cd4d6228c6b20695c38f5a7: 8293164: Remove unimplemented Generation::print_heap_change
• 6e6202c14d0f6dd26369f21883ff317057aa469f: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures
• 17283cfe4c697e2118f19992a6e87dbee268061e: 8293011: riscv: Duplicated stubs to interpreter for static calls
• 607612899678234c093dc644d3a40cb831c7e43b: 8292008: Transition the JDK to the common standard of C11
• 6f297346dc34f58d10c64a7bbe4e0f5b52ed33e3: 8293178: Remove obsolete properties from javadoc resource file
• dd5415309a9235c4e7ced84890457fe7c11c4e96: 8293162: Drop support for VS2017
• 12317ef7d001f5a29c731238dc06ccfd0c97f1e6: 8293046: Move CDS command-line flags to cds_globals.hpp
• 372fc58e897d25713db0dfe289ed25c40d9a3985: 8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java
• 3c1bda4bc3ad81ebabdd9ae05de53ff16f555027: 8293019: [JVMCI] change ratio of libgraal to C1 threads and use one isolate per libgraal thread
• ... and 517 more: https://git.openjdk.org/jdk/compare/87340fd5408d89d9343541ff4fcabde83548a598...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk[bot]]

Going to push as commit 495583524976fb63575b9a45f329e535e490dc80. Since your change was applied there have been 581 commits pushed to the master branch:

• ef20ffe4d222d48f0bdba81a0b864d9fb455e9a6: 8293159: Use try-with-resources in X11FontManager.registerFontDir
• 056ed48ddaa9378793616cf966501cc9536f336a: 8293180: JQuery UI license file not updated
• dbb2c4b6ac01d2a3367a2354213d3b4230dfbb96: 8288897: Clean up node dump code
• 9833c025fd7daf6bb1be81d93148a4204a9f184c: 8292946: GC lock/jni/jnilock001 test failed "assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed()) failed: Twice in a row"
• d7536588b38e368eaa6395bcbcc6724a39303fc5: 8293107: GHA: Bump to Ubuntu 22.04
• d4e3e69505db1b114afec2f6a61acf1261a8e69c: 8293344: JDK-8242181 broke stack printing for non-attached threads
• 2c61efe3de9095631077aaf67edd2695edac6259: 8282648: Weaken the InflaterInputStream specification in order to allow faster Zip implementations
• e31c537f0583261ac326cb74fd90c155629e1b50: 8293224: Add link to openjdk.org/jtreg/ from doc/testing
• 955baa3c44805538df5f95ccc91d2d5a08c85b81: 8267374: macOS: Option+Up/Down Arrow don't traverse to beginning/end of line in JTextArea
• 8df671c908d10b586540cc916a91e083c6098648: 8293355: JDK-8293167 included bad copyright header
• ... and 571 more: https://git.openjdk.org/jdk/compare/87340fd5408d89d9343541ff4fcabde83548a598...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@lahodaj Pushed as commit 495583524976fb63575b9a45f329e535e490dc80.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.