Jan Lahoda

Results 98 comments of Jan Lahoda

Unless there are objections, I would like to integrate in a few days.

I concur with @dbalek and @sdedic - while exposing a package to be public is easy, we then need to take care of it as an API for a long...

Nice work. Some functional comments: - I understand the argument of not consuming much resources by checking every `.add`, etc., method in absence of any `List/Set.of`. OTOH, note the hints...

So, overall, I am not convinced this is a good move. Yes, we have some existing cases where missing stuff produces just warnings in the class reader, but these are...

I was looking into this a bit more. I am afraid I don't see any really good solution. So, out of the not-so-good solutions, the original solution seems least problematic....

If it was only for methods (and possibly fields), then using the completers might work at this time, as we don't use completers on those for anything else (I think!)....

@jddarcy, I am afraid this is a bit in a gray zone. Consider this sequence of projects/files: ``` ----------- ./prj1/src/A.java public class A {} ----------- ./prj2/src/B.java import java.lang.annotation.ElementType; import java.lang.annotation.Target;...

FWIW, a recent fix that fixes an NPE on the same place: https://github.com/openjdk/jdk/commit/ac046628edaee66d1469c49864b70bdefee6570e it is hard to tell if it is the same as here, but certainly possible. Will be...