Lars Grüter

Hey @naik24, welcome. Thanks for offering to work on this. :blush: Do you have experience with this kind of work? Just to be clear up front about this. This looks...

Agreed, dispatching in binary_dilation/closing to the faster functions seems like the way to go for now. As well as an update to the docstrings.

:+1: on the deprecation approach. As long as we explain how to use alternatives properly with regards to mirroring and even-sized footprints. :) Feel welcome to request a review from...

The test failures seem unrelated, so don't worry about those for now if local testing passes for you.

Oh, could you explain which step precisely is not working for you? We could also head over to https://skimage.zulipchat.com/#narrow/channel/176554-Technical-problems to debug this and keep the comments in this PR focused....

Thanks for reaching out. This message indeed seems worth looking into. Unfortunately I can't reproduce it on my side. Therefore a few follow-up questions. Does this warning appear in context...

https://github.com/scikit-image/scikit-image/pull/7486 changed the default role to address the warning. However, this may not be a proper fix. We will have to monitor https://github.com/sphinx-doc/sphinx/issues/12589 and see how that issue is resolved.

Yes, it seems resolved now. Can always reopen if this resurfaces. :)

> the unit tests for the EllipseModel are not very robust. Yeah, any improvement to their robustness would be very welcome! :pray: I remember them as having created noise on...

I'm neither on arm64 nor on a Mac, so it's difficult for me to reproduce or debug this locally. >> I also notice inv calls in that function, which are...