Lars Grüter

Results 496 comments of Lars Grüter

I think it's unlikely that this is caused by you. I think I've seen that before but it's kinda flaky so nobody has really taken the time yet to debug...

By the way, I fully intend to get back to this, but other things take priority right now. Sorry! :pray:

I'm thinking how to best go about updating the test suite considering review experience and long-term maintenance. The test's are somewhat strewn about over at least 2 files. So my...

My personal gut feeling is that `rectangle` isn't too abstract for our users to understand that it also entails `squares`. I could live with keeping `footprint_cube` as a 3d-specific alias...

Hmm, I'm rather fond of "rectangular" which works for any number of dimensions, e.g. rectangular cuboid, square, hyper-cube. `footprint_rectangle` makes it less clear that this function may also work for...

Thanks @mkcor! Do you have a preference or thoughts with regard to `footprint_rectangular` and `footprint_rectangle`? -- > I think that's the problem: rectangular means rectangular something, and the name doesn't...

> leave the "legacy" specialized names, or at least their `footprint_` prefixed version to help those that have been using those all along, and cross reference the relevant generalization in...

@mkcor, `footprint_rect` would be a way to sidestep this but how would we name the other cases, e.g., ellipsis, circle, sphere, ball? Also, I'm usually not a fan of contractions...

I'll leave pressing the merge button to one of you, in case we have a consensus. :wink:

By the way, [DIPlib uses "rectangular"](https://diplib.org/diplib-docs/dip-StructuringElement.html#dip-StructuringElement-ShapeCode).