Lars Grüter

Very sorry for the late response! This got lost in the churn. In my opinion this sounds like useful thing to have in scikit-image. I'd be happy to review a...

Though, we can only include code that is compatible with our [license](https://github.com/scikit-image/scikit-image/blob/main/LICENSE.txt). Not sure if that's the case for the linked implementations above.

As discussed with @stefanv, I'll work on this right now. (see also this [comment](https://github.com/scikit-image/scikit-image/pull/7576/files#r1834988738))

Just curious why you chose to use a merge commit instead of squashing here? The PR commit history doesn't seem particularly useful to preserve?

Yes, thought so to. At least we are now catching these in places where we are using `assert_stacklevel`.

Also, have you looked at this from a performance perspective? Is the new overhead due to a mask (even if not given) significant?

Hey just to keep you in the loop, I'll be traveling next week but I intend to review and get this in after the that. Please feel welcome to ping...

Thanks for the updates @faisaljayousi. Unfortunately, I found a significant problem with our optimization in https://github.com/scikit-image/scikit-image/pull/7544#discussion_r1821313407. We'll probably need to revisit the approach. Sorry for leading you on a wild...

I fear that the best solution right now is to duplicate code from `_glcm_loop` that is only used when `mask is not None`. That way the unmasked case isn't slowed...

Hmm, when I introduce a `mask is not None` check in the inner loop, like so ```python for r in range(start_row, end_row): for c in range(start_col, end_col): ... if mask...