Lars Grüter
Lars Grüter
I concur with @hmaarrfk. In a vacuum option 1 seems most intuitive to me. However, it also seems like something that changes output for the same input. We have a...
See also https://github.com/scikit-image/scikit-image/issues/7811 which has direct consequences on which default we should chose going forward.
> `threshold_rel` is the only default that will make any sense with arbitrarily scaled data. I agree. > I think we may be able to move that to a default...
Thanks for the review @mkcor!
In reply to the broader discussion around the kinds of thresholds (https://github.com/scikit-image/scikit-image/pull/7797#pullrequestreview-3032316593): I'm not sure I completely understand the implications of applying `thresholds` to the space of the Hessian Determinant...
Marking this as a "draft" again while we are focusing on an alternate approach. @stefanv, @matthew-brett and me had a discussion around this. Stéfan is writing a summary of the...
Closing now that work has started in https://github.com/scikit-image/scikit-image/pull/7858.
@michaelbratsch, I took the liberty to push a few changes, since I figured showing would be easier than telling in this case. Please feel very welcome to tweak further or...
Oh, feel free to ignore the failures on MacOS for now. We need to fix that, hopefully soon.
I was so confused for a minute, why this PR-branch is passing on MacOS even though you didn't merge the fixes from https://github.com/scikit-image/scikit-image/pull/7414. I think it's because GitHub runs the...