Lars Grüter

Results 496 comments of Lars Grüter

Okay, what do you think about the following refactored existing API and grouping? #### Scalar threshold(s), global, histogram-based ```python threshold_otsu(image=None, *, nbins=256, hist=None) -> float threshold_yen(image=None, *, nbins=256, hist=None) ->...

Question: what do we want to do about https://github.com/scikit-image/scikit-image/blob/d480b0eb4fba283405fdd91b459d80b6230fe24d/skimage/filters/thresholding.py#L593 That appears as a private function but it's used in our [plot_threshold_li](https://github.com/scikit-image/scikit-image/blob/d480b0eb4fba283405fdd91b459d80b6230fe24d/doc/examples/developers/plot_threshold_li.py#L19) gallery example. My first impression is to make it...

Great news the compilation works now. However, the [tests fail](https://github.com/scikit-image/scikit-image/actions/runs/8889706498/job/24408506922?pr=7407#step:6:1259)... ``` =========================== short test summary info ============================ FAILED measure/_moments.py::skimage.measure._moments.moments_hu FAILED measure/tests/test_fit.py::test_ellipse_parameter_stability - AssertionError: Arrays are not almost equal to 7...

@stefanv do you maybe want to take a look at the failing `test_ellipse_parameter_stability`?

This doesn't seem to be a problem anymore. Not sure why but still happy to close this. 🤷

Thanks for the report. I can reproduce this. Not sure right now about the best way to handle this because I'm not sure where the actual problem starts. Does `moments_central()[0,...

I'm probably missing something but could you clarify? I can't reproduce with ```python import numpy as np import skimage as ski mask = np.ones((10, 10), dtype=bool) mask_ref = mask.copy() ski.morphology.skeletonize(mask)...

I closing this. Please feel very welcome to reopen, in case you would like to add something or think this is still relevant. :)

Closing this for now since it seems like this is intended behavior. Please feel very welcome to reopen this if you'd like to continue the discussion.

Alright, I pushed an alternative deprecation approach that keeps `imread`, `imsave` and `imread_collection` around but deprecates everything that has to do with the plugin infrastructure. https://github.com/scikit-image/scikit-image/pull/7552 should be merged before...