Lars Grüter comments

Results 496 comments of


                                            Lars Grüter

Deprecate function `plot_matches` in favor of `plot_matched_features`

Btw I relabeled this as an API change as it involves a deprecation. We've used "type: Maintenance" mostly to categorize internal stuff that's of no interest to users.

Deprecate function `plot_matches` in favor of `plot_matched_features`

Merging. Thanks @mkcor! One more item of the [list](https://github.com/scikit-image/scikit-image/wiki/API-changes-for-skimage2). :heavy_check_mark:

Addressing the input check bug for pixel_graph (#7233)

Thank you @mao1756. :)

Proposal: sort draw.ellipse coordinates by default to make sure they are all contiguous

Seems very sensible. :+1:

Proposal: sort draw.ellipse coordinates by default to make sure they are all contiguous

hey @RitikaxShakya, this has been taken up in https://github.com/scikit-image/scikit-image/pull/7232. Though, it seems that work on has stalled a bit. Let's wait a few days to see if @anamfatima1304 wants to...

Proposal: sort draw.ellipse coordinates by default to make sure they are all contiguous

Hey @RitikaxShakya, if you are still interested, I've marked https://github.com/scikit-image/scikit-image/pull/7232 as ready to take over. :pray:

Deprecate output and positional args in `filters.gaussian`

Thanks for the review @mkcor. I am currently working on merging and updating our `remove_arg` and `deprecate_kwarg` decorators. IMO we can combine them into a simpler `deprecate_parameter` that allows replacing...

Deprecate output and positional args in `filters.gaussian`

@mkcor, sorry for the "Marked as resolved / unresolved" spam, I got confused. :see_no_evil: This should be ready to review / merge.

Deprecate output and positional args in `filters.gaussian`

@scikit-image/core, this would be good to prioritize as a step towards skimage2. :pray:

Deprecate output and positional args in `filters.gaussian`

Good call @soupault. I forgot to update the original intention in the PR description. I originally wanted to turn `sigma` into a keyword-only parameter as well but then decided to...