Lars Grüter
Lars Grüter
Hey @pohlt, welcome! :) Thanks for the suggestion and especially the context around it. At a first glance this seems like a good fit. From our [review guide](https://scikit-image.org/docs/dev/development/core_developer.html#how-to-conduct-a-good-review) > In...
@stefanv would be the expert on licensing issues. But I think ideal would be if the author commented here (or in public somewhere else) that he makes the code available...
Thank you @pohlt for reaching out and thank you @yukun-lai for the kind licensing of your code! I kind of feel bad for thinking about this only now but since...
> A first implementation is ready: https://github.com/pohlt/scikit-image/blob/co/__co/co.ipynb Thanks so much for working on this. I have a few questions: - These functions currently take in a histogram `(x, h)` correct?...
Adding additional parameters if the histogram is to be calculated is something that we could totally do. Could you explain why the algorithm needs to know these min and max...
... or would this function cease being useful because we would stop using intensity conventions for images alltogether?
Note that there is also https://github.com/scikit-image/scikit-image/pull/4165 which has been in the work for quite some time. It also uses cKDTree so the same limitations to how distance is calculated applies....
Thanks for the advice. What I take from the linked guide is: - Before NumPy 2.0.0rc1, use an upper bound
I added support for anisotropic data to https://github.com/scikit-image/scikit-image/pull/4165. That function can be run on the labeled output of `peak_local_max` to ensure a correct distance. Additionally, we could try to implement...
@jarrodmillman, in yesterday's meeting I suggested that I make a minor release 0.22.1 with the `numpy