Results 229 comments of Bernard Kwok

Hi @dbsmythe, I am curious what cases can not be covered and what do are your thoughts on addressing these ? It would be useful to enumerate these but I...

This is the detailed examination for implementation. Summary in main description. # Functional NodeDef Implementation Changes ## Logic To Examine / Update ### Existing NodeDef association back search - `NodeGraph::getNodeDef()`...

Runnable code is now available in the Draft PR #2401.

One case which cannot be handled is referencing of functional nodegraphs by different definitions. This was added in for `standard_surface` to handle definitions with different default values between versions: ```...

Hi @ld-kerley, This is an intriguing idea and I think fits nicely into what is already there. I remember now that I added in support for { nodedef : nodegraph...

This looks great! - The requirement should simply be sRGB display linear conversions so if you're ready a pull request can probably be put up. - Here is a simple...

Some initial comments / questions. 1. I can see the need to have a placeholder to replace values with the per-type values. I am curious is this a pre-cursor to...

The image addressing modes also hav unexpected "shading" for vclamp, and umirror. There are no bxdf nodes in this test. The other modes do not show this.

Leaving a ping with @dleex and @lkerley as a heads up. I'd like to propose that the Metal results be used as the "reference" for hardware rasterizers but need input...

Thanks for looking into these diffs. I saw that the color clamp sets no mode at all. Maybe someone could take a look. Frankly, some of these modes are super...