PHP-CS-Fixer icon indicating copy to clipboard operation
PHP-CS-Fixer copied to clipboard
verified publisher icon PHP-CS-Fixer

Issue #4361: Implements the ClassAnalyzer and its tests.

Open drupol opened this issue 7 years ago • 9 comments

Fix #4361

drupol avatar Apr 06 '19 09:04 drupol

I just rebased the branch against latest 2.12 branch.

drupol avatar Jul 22 '19 19:07 drupol

This needs more work. I will finish it tonight.

drupol avatar Jul 23 '19 09:07 drupol

This is now ready for another round of review.

@SpacePossum @keradus @dmvdbrugge @localheinz

drupol avatar Jul 23 '19 16:07 drupol

In Tokenizer/Analyzer we have ArgumentsAnalyzer, CommentsAnalyzer and so on - I mean have plural names - therefore can we rename this analyzer to ClassesAnalyzer?

kubawerlos avatar Jul 28 '19 17:07 kubawerlos

In Tokenizer/Analyzer we have ArgumentsAnalyzer, CommentsAnalyzer and so on - I mean have plural names - therefore can we rename this analyzer to ClassesAnalyzer?

Fair enough. Done!

drupol avatar Jul 28 '19 17:07 drupol

@keradus can you look @ this one and https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4310 ?

SpacePossum avatar Jan 07 '20 12:01 SpacePossum

Any news on this @SpacePossum

drupol avatar Feb 04 '20 19:02 drupol

please ping @keradus on this :)

SpacePossum avatar Feb 04 '20 20:02 SpacePossum

Dear @kubawerlos, I adressed most of the points of your review.

Let me know what I should do to move this forward ;-)

drupol avatar Apr 15 '20 19:04 drupol