Eric Robinson
Eric Robinson
> A bit hard to judge compared to the original (or even to what one would consider "perfect", which I actually don't know), but that's looking good to me at...
Gotta redo time demo probably 😅 I incorrectly named the tables so I'll need to revise those.
> This breaks the time demo is that really expected? > > Also there is a conflict, please resolve. done
@julealgon You did see that this is arena only right? Are there any compelling reasons this shouldn't be in the arena?
> > @julealgon You did see that this is arena only right? Are there any compelling reasons this shouldn't be in the arena? > > I did, but I still...
> > > > @julealgon You did see that this is arena only right? Are there any compelling reasons this shouldn't be in the arena? > > > > >...
My response was a bit tongue in cheek but moreover food for thought. I don't believe the fix was a mistake, but it reasonably could be viewed as a mistake...
> Would it be better to extract this as a member function in the player class? Yes actually. I think it would be cleaner if kept into it's own function....
Currently doesn't work as intended