pkg icon indicating copy to clipboard operation
pkg copied to clipboard

`WantDeleteCollections` was never implemented in `TableTest`

Open mattmoor opened this issue 3 years ago • 5 comments
trafficstars

/area API /area networking /area test-and-release /kind bug /kind good-first-issue

Expected Behavior

A TableTest with WantDeleteCollections verifies things work!

Actual Behavior

It silently ignores DeleteCollection calls.

See also: https://github.com/knative/pkg/blob/d2cdc682d97482be4d71bfd34f2ab000f7070dd4/reconciler/testing/table.go#L75

mattmoor avatar Mar 10 '22 01:03 mattmoor

Ok, I'm like 90% sure that this isn't currently possible because of: https://github.com/kubernetes/kubernetes/issues/105357

mattmoor avatar Mar 10 '22 01:03 mattmoor

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jun 08 '22 01:06 github-actions[bot]

/lifecycle frozen

mattmoor avatar Jul 08 '22 01:07 mattmoor

/reopen

mattmoor avatar Jul 08 '22 01:07 mattmoor

@mattmoor: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar Jul 08 '22 01:07 knative-prow[bot]