Krisztian Litkey

Results 285 comments of Krisztian Litkey

b> Hi! userns KEP author here. I'm not very familiar with the CDI injection process to provide more input. do you have any links I should read? @rata No, unfortunatly...

> > Currently if an injected device node does not come with UID/GID's or permission bits specified in the CDI Spec, IIRC we take a look at the corresponding device...

@everzakov @rata @elezar What is the verdict for this PR ? IIUC, we shouldn't try to extend this with extra logic for devices, because it won't work due to how...

Ping @everzakov @rata. What do you guys think ? Should we take this in ?

@elezar @oreillymj I suspect that either option or type is optional but not both. IOW, you need to have at least one of them, but it depends on the specifics...

> [@elezar](https://github.com/elezar) [@oreillymj](https://github.com/oreillymj) I suspect that either option or type is optional but not both. IOW, you need to have at least one of them, but it depends on the...

> [@klihub](https://github.com/klihub) the fix in the PR looks reasonable. Does this also mean that we need to extend the CDI spec to allow these fields to be specified in mounts...

> This change would make [containers/nri-plugins#327](https://github.com/containers/nri-plugins/pull/327) redundant. I rolled this PR actually with that CDI injecting NRI plugin in mind (I mentioned this in the initial review of that plugin...

@zxj874478410 This fix is not sufficient in it's current form as it breaks replacing a mount with another one to the same destination. I think we'd need a bit of...