Krisztian Litkey

> Yeah I was wondering as well if there's either existing utilities in https://github.com/opencontainers/cgroups or https://github.com/containerd/cgroups that could be used (or added) and could be used for the implementation. >...

Hmm... changing the IPC and network namespace seems a bit extreme. A failure to inject with an appropriate error message in a case where a device requires host IPC or...

> @klihub @chrishenzie @mikebrow > > Pre-work for some of my upcoming work on managing the `linux.intelRdt` object of the runtime-spec. I decided to submit this one as a separate...

nit: typo in the body of commit message for 'api: add rdt': repeated 'the' in "... the the IntelRdt message is sepate from LinuxResources. This is to ..."

@marquiz @mikebrow @chrishenzie This overall LGTM. My biggest question is the timeline for tagging a new opencontainers/runtime-spec so that bits we rely on here become available via a tagged release.

> I just recalled that there's actually one aspect/feature missing from the new extensions: ability to remove the `linux.intelRdt` from the container config (set it to nil/null). Suggestions for how...

> > I'd vote with a mild bias for 2 above (because it's how we handle other similar cases where removal is supported). But with the addition that on the...

nit: typo/missing 'be' in commit message of 'api: add rdt': "Also note that the Rdt object cannot modified on container"

As a purely theoretical question related to your notes in the commit log of 'api: add rdt'. In the (I am adraid highly unlikely) situation where runc/crun/OCI compatible runtimes would...

In pkg/topology the -host-root flag should be applied: https://github.com/containers/nri-plugins/blob/19bbdd5438fd30bf09c7e33930a5877b9f4b4418/pkg/resmgr/resource-manager.go#L93. The others are probably not set correctly. Some of those are also unused. And, for instance, I'm not sure if we...