Krisztian Litkey
Krisztian Litkey
Incorrecnt/insufficient sysroot usage in the `pkg/topology` package has been fixed and should work now correctly.
> Looking at the governor solution in high level (first implementation and this patch), I'm starting to think that we are adding unnecessary complexity. And I'm slightly worried about it,...
> In my opinion, we should not introduce a fatal failure due to missing parameters for a CPU class. +1. Definitely not.
v0.7.1 tagged and [released](https://github.com/containers/nri-plugins/releases/tag/v0.7.1).
> @klihub is there a version of the OCI runtime spec that includes these fields now? @elezar Not with a tagged version yet, unfortunately. > Could we update this PR...
> It seems as if the v1.3.0 spec has been tagged. Yes, but I think we'll need for https://github.com/opencontainers/runtime-tools/pull/795 (and https://github.com/opencontainers/runtime-tools/pull/797) to get merged.
> @klihub lgtm. Do we need to update/add any tests for the new fields? @bart0sh Yes, I think we'd need those and they are missing now. I'll add them.
> @klihub lgtm. Do we need to update/add any tests for the new fields? @bartosh Added test for injecting and validating net devices. Updated the schema to mark both host...
Ping @elezar, PTAL.
> Is something similar required for devices since the uid and gid in the spec are the IDs in the container (https://github.com/opencontainers/runtime-spec/blob/main/config-linux.md#devices)? At least nothing identical we can do for...