Krisztian Litkey
Krisztian Litkey
> In general, I'm ok with all of this. One separate worry that I have is about "unsafe.Pointer()" cast for practically 100% of data structures: does match in all cases...
> LGTM. Right now the option is enabled by default, is the plan to disable it by default or remove it, in the future? Yes, that's exactly what I had...
> Tested on debian-sid with > > * kubelet v1.19.0 (CRI v1alpha2) + containerd v1.6.0-41-gc523102b5 > * kubelet v1.23.4 (CRI v1) + containerd v1.6.0-41-gc523102b5 > ...and it works fine. >...
@askervin @jukkar @kad @marquiz PTAL, I had to rebase this already approved one to resolve a conflict.
@kad, @marquiz, @askervin, @jukkar I consider merging this for the `0.7.0` release... WDYT ?
> @kad, @marquiz, @askervin, @jukkar I consider merging this for the `0.7.0` release... WDYT ? Okay, after testing that idea against our current e2e test set, it's better to keep...
@kad @marquiz @askervin @jukkar @fmuyassarov Once we are 100 % sure that we don't want/need to support any `containerd` or `cri-o` version which does not speak CRI v1, this should...
> `distro=ubuntu-20.04`: fail (containerd-1.5.9) ... > ubuntu-20.04 end-of-life is Aug/2025. What do you think? I'm trying to become a better human being, so I can't/won't tell you that... But I...
> > 3. If we think there is a viable more recent alternative to 20.04, we stop supporting it despite it not being EOL'd. > > Hmm, please do not...
> > > 3. If we think there is a viable more recent alternative to 20.04, we stop supporting it despite it not being EOL'd. > > > > >...