Sergii Dymchenko comments

Results 140 comments of


                                            Sergii Dymchenko

`mul`: sparse-dense + sparse-sparse with 0-dims support take 2.

@nikitaved looking at this, thanks.

`mul`: sparse-dense + sparse-sparse with 0-dims support take 2.

I've imported this internally and I don't see any failures, LGTM. I'm copy-pasting bunch of internal CLANGTIDY warnings (not sure why none of them shows on GitHub, need to investigate)...

`mul`: sparse-dense + sparse-sparse with 0-dims support take 2.

@nikitaved I don't see any issues, feel free to merge. Also not sure what do you mean about potential privileges issues upon merge, there should not be any.

Testing cublas static linking removal

@atalman is this still needed?

Spellchecker incorrectly accepts spelling 'decleration'

So I tried it with Python and recent VSCode and vscode-spell-checker, all default settings, the extension doesn't mark "decleration" as wrong (but it marks "decleretion" as wrong).

C/C++: Some misspelled words are not detected

I see the same with Python. For example, "singal" is not detected, presumably because it's "sing" + "al". I thought that the `cSpell.allowCompoundWords` would control this behavior, but apparently not...

Improve and expose cpp_backtrace to python binding

@pytorchbot revert -m "Broke libtorch and linux-binary-manywheel - https://hud.pytorch.org/pytorch/pytorch/commit/73fbca1ea6ecc08ae4455a12b68fc2ead93a088c" -c nosignal

Improve and expose cpp_backtrace to python binding

`lib/libc10.so: error: undefined reference to 'dladdr'` - probably shouldn't use `merge -g` for this kind of somewhat risky PRs. `merge -l` (which should be default now) would have caught it.

Remove deprecated torch.lstsq

@IvanYashchuk LGTM, feel free to merge.

Remove deprecated torch.lstsq

@pytorchbot merge -g