Sergii Dymchenko

Results 140 comments of Sergii Dymchenko

@khushi-411 Is this still relevant?

@khushi-411 The failure on MPS is actually unexpected success: ________ TestErrorInputsMPS.test_error_inputs_nn_functional_conv1d_mps _________ Unexpected success Maybe the PR just fixed it on MPS? If yes, just remove the expected failure from...

I'll help to make sure next the merge will not break Meta-internal stuff.

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D42354776).

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D42354776).

Here is the XLA test that needs to be updated: https://github.com/pytorch/xla/blob/master/test/cpp/test_aten_xla_tensor.cpp#L1887

@peterbell10 @dagitses is this something we want to merge now?