Sergii Dymchenko
Sergii Dymchenko
Should we close this?
Sounds like a good idea. I personally helped people who had this issue.
This seems a bit tricky to implement. Currently TorchFix doesn't know the types of the objects, so it's hard to find lists of `torch.nn.Module` objects. pyre and `TypeInferenceProvider` https://libcst.readthedocs.io/en/latest/metadata.html#libcst.metadata.TypeInferenceProvider can...
I think that's fine that sometimes autofix is not correct, as it's not possible to make it work correctly in every case. From README: > Please keep in mind that...
And maybe it's possible to detect some cases when `use_reentrant=False` certainly will not work statically from the code?
> > Please have CMakeLists.txt formatting changes in a separate PR. > > Pretty sure lint would break if that was done as the only formatting here is done by...
@pytorchbot revert -m "Reverted internally at Meta, see D65979564" -c ghfirst
@XuehaiPan Not really about this PR, but maybe you have ideas/suggestions how we can integrate `deprecated` decorators with TorchFix https://github.com/pytorch-labs/torchfix ?
@wangxiyuan Let's not try merging these PRs before importing internally to Meta, otherwise very likely they will be reverted. Please ping me when you have one of these PRs ready...
@wangxiyuan @thiagocrepaldi Why does this PR update to `torch.onnx.utils._export`? The docstring says "Please use `torch.onnx.export` instead."