Sergii Dymchenko
Sergii Dymchenko
@pytorchbot merge
@pytorchbot revert -m "Broke internal tests, see D54230858" -c ghfirst
@peterbell10 Sorry for the absence of the revert details, it's not clear what exactly happened in the moment. The failed test is in the internal user code, not in the...
@peterbell10 I've got suggested this hypothesis for the internal failure: It is possible that the diff introduced rounding and precision problem here `w2_over_w = tl.where(new_weight == 0.0, 0.0, div_approx(weight_2, new_weight))`
@peterbell10 I'll find someone to follow-up.
The actual changes are in the first commit. The rest are to fix unrelated pre-existing issues in the files to pass lint.
I removed devx label. It's a question of policy. I actually raised a similar proposal some time ago, but was met with a firm "issues never get stale".
@IosifSpulber The description "Summary: Split from the main diff in the stack" doesn't make sense in open source context. Please provide better PR description.
@pytorchbot merge -f "Will fix the lint separately to avoid fbcode discrepancy"
@cyyever please make all changes outside of caffe2 in a separate PR. Otherwise it's a huge pain to land internally.