pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

`mul`: sparse-dense + sparse-sparse with 0-dims support take 2.

Open nikitaved opened this issue 3 years ago • 4 comments

This one is a copy of https://github.com/pytorch/pytorch/pull/81556 https://github.com/pytorch/pytorch/pull/82717 These got reverted due to issues with torchvision.

CC @kit1980 , could you please take over from here?

nikitaved avatar Aug 08 '22 10:08 nikitaved

:link: Helpful links

:white_check_mark: No Failures (0 Pending)

As of commit 9d9893a1b9 (more details on the Dr. CI page):

Expand to see more

:green_heart: :green_heart: Looks good so far! There are no failures yet. :green_heart: :green_heart:


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot avatar Aug 08 '22 10:08 facebook-github-bot

@nikitaved looking at this, thanks.

kit1980 avatar Aug 09 '22 16:08 kit1980

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 09 '22 16:08 facebook-github-bot

I've imported this internally and I don't see any failures, LGTM.

I'm copy-pasting bunch of internal CLANGTIDY warnings (not sure why none of them shows on GitHub, need to investigate) - these are not strictly required, but please take a look.

kit1980 avatar Aug 10 '22 02:08 kit1980

Thank you, @kit1980 , for your comments! Unless there is anything else, can I merge it on green? @bhosmer , could you please stamp it just to be sure we do not run into privileges issues upon merge? Thank you!

nikitaved avatar Aug 11 '22 12:08 nikitaved

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 11 '22 16:08 facebook-github-bot

@nikitaved I don't see any issues, feel free to merge. Also not sure what do you mean about potential privileges issues upon merge, there should not be any.

kit1980 avatar Aug 11 '22 21:08 kit1980

@kit1980 Ed had an issue with merging his contribution marked as sparse unless sparse people approved that, hence the concern. Thanks for taking care of this! Let me try to see if this is the case here...

nikitaved avatar Aug 11 '22 23:08 nikitaved

@pytorchbot merge

nikitaved avatar Aug 11 '22 23:08 nikitaved

@pytorchbot successfully started a merge job. Check the current status here. The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki. Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot avatar Aug 11 '22 23:08 pytorchmergebot

Hey @nikitaved. You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'. For changes that are 'topic: not user facing' there is no need for a release notes label.

github-actions[bot] avatar Aug 11 '22 23:08 github-actions[bot]