killianmuldoon
killianmuldoon
>How about also adding the zz_generated go files. Looks like github already does that using [this check](https://github.com/github/linguist/blob/2aee6a16a6423a3727a69ce5d53c964fae69cd8e/lib/linguist/generated.rb#L318) (thanks for finding this @killianmuldoon) but it might be good to make it...
>Or does it only hide it on the GitHub PR diff? But I also find it rather confusing if we can't see the diff there anymore. This only hides the...
/assign I'll get working on this
@abhijit-dev82 Are you able to run the full `make generate` target locally?
A couple of things I've found in another round of review / testing: 1. I'm not able to set the value on a Cluster's control plane - instead I'm getting...
Good to see it's working! /hold until #7047 merges.
/unhold Fix for the handling of duration is now merged.
@DiptoChakrabarty are you able to bring tilt up with this PR as is? I'm getting a number of errors when trying to run this change.