killianmuldoon
killianmuldoon
> So I temporary allowed unused in nolintlint until revive is fully enabled again. I this ok? Yeah - that's perfectly fine I think.
golangci-lint 1.48.0 is now released, and [it looks like there's not going to be another release for a little while](https://github.com/golangci/golangci-lint/issues/2997#issuecomment-1216830262). I think we should update CAPI to golangci-lint 1.48.0. I...
>Running make lint-fix changes them and then the verify-boilerplate.sh script fails. Looking at it. I've also been trying to pin this down on https://github.com/kubernetes-sigs/cluster-api/pull/7066/files#diff-c5a9f9e91fea8f113dbe8cc4feece40bed422499e3372094ae037f119b94ff78 I'll share anything I find -...
I managed to resolve the header issues over at: https://github.com/killianmuldoon/cluster-api/pull/31 I didn't need to change the boilerplate there's just a small number of the files that have a special character...
@abhijit-dev82 this is where I'm figuring out a fix for https://github.com/kubernetes-sigs/cluster-api/pull/7031
Failed run before fix here: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/7047/pull-cluster-api-e2e-informing-main/1557400014039289856
We should probably cherry pick this to 1.2 give it's a broken feature that was including in that release. /cherry-pick release-1.2
It looks like the current behaviour of paused is different depending on whether you set the spec field or the annotation? With the annotation you get no reconciliation, but with...