killianmuldoon

Results 179 comments of killianmuldoon

> How would an empty selector look like for the names slice that we have today? ``` matchResources: machineDeploymentClass: {} ``` That's my understanding of how it normally works in...

The issue seems to be your env test setup - do all the tests run when you run `make test` ? You may need to set the `KUBEBUILDER_ASSETS` env variable

The CR definitions are created using `make generate` and its sub-targets. `make generate` takes a long time to run, so you might want to just run `make generate-manifests` and maybe...

@valaparthvi When I run `make generate-go-openapi` locally I get changes in ` api/v1beta1/zz_generated.openapi.go`. Could you share some information about the environment in which you're running the command? e.g. cluster api...

I'm really not sure what the base issue is here at this point 🤔, and I don't know what the next steps to look for a solution are. Just as...

Can you show what the rest of the path is under those newly created github directories?

>There is code in Makefile that should make this work even if the repo is cloned outside the GOPATH. I wonder why it did not work. Yeah - I tried...

This is shaping up nicely! There's still a change needed in the webhook to enable creating ClusterClasses with the empty selector (and a test to show it's working) The relevant...

I think we should add some tests to the webhook to cover the following cases: 1. Matching all MDs works to select multiple MachineDeployments when the selector is empty i.e....