cluster-api
cluster-api copied to clipboard
kubernetes-sigs
:sparkles: Add topology field for NodeDeletionTimeout
What this PR does / why we need it: Make NodeDeletionTimeOut field in MachineDeployment configurable.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6450
/kind feature /area topology
Welcome @abhijit-dev82!
It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
@abhijit-dev82: This issue is currently awaiting triage.
If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @abhijit-dev82. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval by writing /assign @vincepri in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@abhijit-dev82 Are you able to run the full make generate target locally?
@killianmuldoon Yes it went through, but I missed pushing an autogenerated file "api/v1beta1/zz_generated.openapi.go", have done that now.
A couple of things I've found in another round of review / testing:
- I'm not able to set the value on a Cluster's control plane - instead I'm getting errors from the webhook. As far as I can tell this is also the case for https://github.com/kubernetes-sigs/cluster-api/pull/6379. This must be down to how the time.Duration is parsed differently between the control plane and the machineDeployment. This is a major bug we should get to the bottom of.
- We should add webhook validation for both this and https://github.com/kubernetes-sigs/cluster-api/pull/6379 (that can be in a follow up PR).
- We should also add these values in our integration tests to check that they're really working. (another follow-up PR)
- Could you update the commit message so it doesn't repeat?
Have you been able to get setting the fields to work on running clusters? I might be missing something about how to set them, but now it looks at the least inconsistent and likely to be broken.
Hey @killianmuldoon I have pushed the changes including your changes to fix the main issue to see if the tests succeed.
@abhijit-dev82: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
HI @killianmuldoon , Had some issues merging the changes , hence had to spawn a new PR, https://github.com/kubernetes-sigs/cluster-api/pull/7098