killianmuldoon

Results 292 comments of killianmuldoon

That said - I think it's probably a good idea to move the setting of `status.ControlPlaneReady` to the same place as the condition is set so there's no difference between...

>The runtime hook was done during a PoC to check if runtime extension could solve some of our internal issues we have when it came to cluster creation. We thought...

Thanks for opening this @furkatgofurov7 /assign I'll take a look at figuring out the current state of this.

@lubronzhan in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/issues/1483 you said that `legacyNodeSelectorKey` and `legacyClusterSelectorKey` labels should be around for one or two releases, but you were waiting for more input. Do you think it's safe...

>Hi @killianmuldoon , I think it's ok to deprecate it now since clusters have been upgraded to newer version. Let me create a PR to remove the legacy one I...

/triage accepted You're right that this is confusing - would be a good idea to clean up the documentation around this. /help

Interesting ideas @haijianyang! Do you have some detail on what use case you're trying to solve with this?