killianmuldoon
killianmuldoon
I'm +1 for replacing it in tests, but I'm not sure about doing so in non-test code. From the go-doc: ``` // It is intended to only be used in...
Yeah - I'm not very worried about performance. I also think we shouldn't have things that can't be compared, given we're almost always going to be comparing the same types,...
/reopen This issue covers replacing the reflect DeepEqual in more places across the codebase than #8266
>I can't figure out if anyone is using these rules at all and why they are different for kind.sh vs help install, added this item to the next meeting agenda,...
The issue for this one was closed as stale due to inactivity - there seems to be no consensus on how to deal with these CRDs.
If I'm reading this right the infrastructureMachine field is not designed to be used with newer versions of the API - it exists for backward compatibility. From https://cluster-api.sigs.k8s.io/developer/providers/machine-infrastructure.html: > failureDomain...
>Sounds like we should remove it? It's just a trip hazard now. I think this will be part of the conversation around removing the v1alpha3 API types in #8071. Part...
In my case I'm trying out a custom health check for a liveness probe which will cause the container to crash if it can't reach the APIServer: ```go func APIConnectionCheck(mgr...
>Sure, I can do that. I was not sure about the first part of the issue though. Something about creationTimestamp, is that done? Yeah - the creationTimestamp issue was a...
Thanks for digging into the errors! Let's track the status of that issue - if it's fixed relatively soon we can update. . AFAIK we only kustomize for generating test...