cluster-api-provider-vsphere icon indicating copy to clipboard operation
cluster-api-provider-vsphere copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Add ability to set label for dynamic passthrough devices

Open maximsnezhkov opened this issue 2 years ago • 2 comments
trafficstars

/kind feature

Describe the solution you'd like [A clear and concise description of what you want to happen.] As an operator I would like to use hardware label to differentiate PCI device of the same deviceID/VendorID. It might be useful to separate device between different workload clusters.

Anything else you would like to add: Nothing else.

Environment:

  • Cluster-api-provider-vsphere version: v1.6.0
  • Kubernetes version: (use kubectl version): v1.22.17
  • OS (e.g. from /etc/os-release): Ubuntu 20.04.6 LTS

maximsnezhkov avatar Oct 29 '23 15:10 maximsnezhkov

/triage accepted

killianmuldoon avatar Oct 30 '23 10:10 killianmuldoon

I think this makes sense.

This does not need an additional implementation for vm operator mode. VM operator mode seems to already support it via VirtualMachineClass:

https://github.com/vmware-tanzu/vm-operator/blob/main/api/v1alpha1/virtualmachineclass_types.go#L23

chrischdi avatar Oct 30 '23 12:10 chrischdi